docs(openapi): remove phantom /sports/{sportId} and /sportsbooks/{bookId} (#205)#218
Merged
Conversation
…kId} Closes #205. Both routes were declared in `public/openapi.json` but never implemented in `sharp-api-go` — every customer call hits the bare Go ServeMux 404 ("404 page not found"). The list endpoints `/sports` and `/sportsbooks` already cover the use case, so per the issue's recommendation we strip the singular path-param variants from the spec. Re-tested the other 5 routes the issue called out and they all resolve on the live origin now (`/account` 200, `/account/keys` 400 for missing input, `/account/keys/{id}` 400, `/account/keys/{id}/rotate` 400, `/account/usage` 200, `/stream` 200 SSE) — those landed in `sharp-api-go` since the issue was filed. Verified: - `npm run build` clean (53 pages, 0 errors) - `python3 -m json.tool public/openapi.json` parses - `grep getSport\b|getSportsbook\b` returns no orphan references in content/ or the spec Removal is byte-targeted (no formatter reflow) so the diff is pure deletions: 124 lines removed from the spec. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #205. Both routes were declared in
public/openapi.jsonbut never implemented insharp-api-go— every customer call hits the bare Go ServeMux 404. The list endpoints/sportsand/sportsbooksalready cover the use case, so per the issue's own recommendation we strip the singular path-param variants.Re-test of the other 5 routes the issue called out
Since the issue was filed (2026-05-04), the
/account/*namespace and/streamwere implemented insharp-api-go. Confirmed against liveapi.sharpapi.io:GET /api/v1/accountGET /api/v1/account/keysPOST /api/v1/account/keysGET /api/v1/account/usageDELETE /api/v1/account/keys/{id}POST /api/v1/account/keys/{id}/rotateGET /api/v1/streamGET /api/v1/sports/{sportId}GET /api/v1/sportsbooks/{bookId}So this PR closes #205 by aligning the spec with the live backend.
Verification
npm run buildclean (53 pages indexed, 0 errors)python3 -m json.tool public/openapi.jsonparsesgetSport/getSportsbookoperationIds in spec or content/x-generated-at/x-commit-shaandenumformatting deltas are the build pipeline's normalJSON.stringify(spec, null, 2)output viascripts/stamp-openapi.mjs)Test plan
🤖 Generated with Claude Code